Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-48474: Replace RunHostCmd with Exec function to censor bearer token being exposed #29377

Open
wants to merge 1 commit into
base: release-4.18
Choose a base branch
from
Open

OCPBUGS-48474: Replace RunHostCmd with Exec function to censor bearer token being exposed #29377

wants to merge 1 commit into from

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #29176

/assign Shilpa-Gokul

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 16, 2024
Merged
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Jira Issue OCPBUGS-42618 is in a security level that is not in the allowed security levels for this repo.
Allowed security levels for this repo are:

  • Red Hat Employee
  • default

In response to this:

This is an automated cherry-pick of #29176

/assign Shilpa-Gokul

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from deads2k and knobunc December 16, 2024 09:04
@Shilpa-Gokul
Copy link
Contributor

/retest-required

1 similar comment
@Shilpa-Gokul
Copy link
Contributor

/retest-required

@Shilpa-Gokul
Copy link
Contributor

/assign @deads2k
Could you please review this backport PR?

@neisw
Copy link
Contributor

neisw commented Jan 10, 2025

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neisw, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2025
@deads2k deads2k added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead). backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. labels Jan 10, 2025
@candita
Copy link
Contributor

candita commented Jan 10, 2025

@Shilpa-Gokul please investigate the failures in the non-required tests and try retesting if they looked like infra failures?
/assign

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 10, 2025

@candita: GitHub didn't allow me to assign the following users: candita.

Note that only openshift members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

@Shilpa-Gokul please investigate the failures in the non-required tests and try retesting if they looked like infra failures?
/assign

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Shilpa-Gokul
Copy link
Contributor

/jira cherry-pick OCPBUGS-42618

@Shilpa-Gokul
Copy link
Contributor

/jira cherrypick OCPBUGS-42618

@r4f4
Copy link
Contributor

r4f4 commented Jan 13, 2025

/jira refresh

@openshift-ci-robot
Copy link

@r4f4: Jira Issue OCPBUGS-42618 is in a security level that is not in the allowed security levels for this repo.
Allowed security levels for this repo are:

  • Red Hat Employee
  • default

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@bradmwilliams
Copy link

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 15, 2025
@openshift-ci-robot
Copy link

@bradmwilliams: This pull request references Jira Issue OCPBUGS-42618, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-42618 to depend on a bug targeting a version in 4.19.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Shilpa-Gokul
Copy link
Contributor

/jira cherrypick OCPBUGS-42618

@openshift-ci-robot
Copy link

@Shilpa-Gokul: Jira Issue OCPBUGS-42618 has been cloned as Jira Issue OCPBUGS-48474. Will retitle bug to link to clone.
/retitle OCPBUGS-48474: [release-4.18] OCPBUGS-42618: Replace RunHostCmd with Exec function to censor bearer token being ex…

In response to this:

/jira cherrypick OCPBUGS-42618

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.18] OCPBUGS-42618: Replace RunHostCmd with Exec function to censor bearer token being ex… OCPBUGS-48474: [release-4.18] OCPBUGS-42618: Replace RunHostCmd with Exec function to censor bearer token being ex… Jan 16, 2025
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-48474, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected dependent Jira Issue OCPBUGS-42618 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is POST instead
  • expected dependent Jira Issue OCPBUGS-42618 to target a version in 4.19.0, but it targets "4.18.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #29176

/assign Shilpa-Gokul

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Shilpa-Gokul
Copy link
Contributor

/jira refresh

@openshift-ci-robot
Copy link

@Shilpa-Gokul: This pull request references Jira Issue OCPBUGS-48474, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected dependent Jira Issue OCPBUGS-42618 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is POST instead
  • expected dependent Jira Issue OCPBUGS-42618 to target a version in 4.19.0, but it targets "4.18.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Shilpa-Gokul
Copy link
Contributor

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 16, 2025
@openshift-ci-robot
Copy link

@Shilpa-Gokul: This pull request references Jira Issue OCPBUGS-48474, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-42618 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-42618 targets the "4.19.0" version, which is one of the valid target versions: 4.19.0
  • bug has dependents

Requesting review from QA contact:
/cc @juliemathew

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 16, 2025

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: juliemathew.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@Shilpa-Gokul: This pull request references Jira Issue OCPBUGS-48474, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-42618 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-42618 targets the "4.19.0" version, which is one of the valid target versions: 4.19.0
  • bug has dependents

Requesting review from QA contact:
/cc @juliemathew

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Shilpa-Gokul
Copy link
Contributor

/retitle OCPBUGS-48474: Replace RunHostCmd with Exec function to censor bearer token being exposed

@openshift-ci openshift-ci bot changed the title OCPBUGS-48474: [release-4.18] OCPBUGS-42618: Replace RunHostCmd with Exec function to censor bearer token being ex… OCPBUGS-48474: Replace RunHostCmd with Exec function to censor bearer token being exposed Jan 16, 2025
@Shilpa-Gokul
Copy link
Contributor

/retest

@Shilpa-Gokul
Copy link
Contributor

/test e2e-aws-ovn-single-node-upgrade

@Shilpa-Gokul
Copy link
Contributor

/retest

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 17, 2025

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node-upgrade 459e9f4 link false /test e2e-aws-ovn-single-node-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@knobunc knobunc Awaiting requested review from knobunc

Assignees

@dgoodwin dgoodwin

@adambkaplan adambkaplan

@kasturinarra kasturinarra

@deads2k deads2k

@Moebasim Moebasim

@jadhaj jadhaj

@pamoedom pamoedom

@gangwgr gangwgr

@Shilpa-Gokul Shilpa-Gokul

@prabhapa prabhapa

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.